Re: Replication identifiers, take 4

On 29/04/15 22:12, David Rowley wrote:
> On 25 April 2015 at 00:32, Andres Freund <andres@anarazel.de
> <mailto:andres@anarazel.de>> wrote:
>
>
>     Attached is a patch that does this, and some more, renaming. That was
>     more work than I'd imagined.  I've also made the internal naming in
>     origin.c more consistent/simpler and did a bunch of other cleanup.
>
>
> Hi,
>
> It looks like bowerbird is not too happy with this, neither is my build
> environment.
>
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2015-04-29%2019%3A31%3A06
>
> The attached seems to fix it.
> I put the include in the origin.h rather than in the origin.c as the
> DoNotReplicateId macro uses UINT16_MAX and is also used in xact.c.
>

I think correct fix is using PG_UINT16_MAX.


--  Petr Jelinek                  http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services