Re: [HACKERS] pageinspect: Hash index support
От | Jesper Pedersen |
---|---|
Тема | Re: [HACKERS] pageinspect: Hash index support |
Дата | |
Msg-id | 551edf28-6133-d714-aa07-e04b6848b7f5@redhat.com обсуждение исходный текст |
Ответ на | Re: [HACKERS] pageinspect: Hash index support (Jesper Pedersen <jesper.pedersen@redhat.com>) |
Ответы |
Re: [HACKERS] pageinspect: Hash index support
|
Список | pgsql-hackers |
On 02/03/2017 11:41 AM, Jesper Pedersen wrote: >>> contrib/pageinspect actually seems to lack *any* infrastructure >>> for sharing functions across modules. It's time to remedy that. >>> I propose inventing "pageinspect.h" to hold commonly visible >>> declarations, and moving get_page_from_raw() into rawpage.c, >>> which seems like a reasonably natural home for it. (Alternatively, >>> we could invent a pageinspect.c file to hold utility functions, >>> but that might be overkill.) >> >> No objections. >> > > Attached is v1 of this w/ verify_hash_page() using get_page_from_raw(). > > Sorry for all the problems. > Disregard, as Tom has committed a fix. Best regards, Jesper
В списке pgsql-hackers по дате отправления: