Re: Using 128-bit integers for sum, avg and statistics aggregates

Поиск
Список
Период
Сортировка
От Andreas Karlsson
Тема Re: Using 128-bit integers for sum, avg and statistics aggregates
Дата
Msg-id 550EBCAA.6030004@proxel.se
обсуждение исходный текст
Ответ на Re: Using 128-bit integers for sum, avg and statistics aggregates  (Petr Jelinek <petr@2ndquadrant.com>)
Ответы Re: Using 128-bit integers for sum, avg and statistics aggregates  (Petr Jelinek <petr@2ndquadrant.com>)
Список pgsql-hackers
On 03/22/2015 11:47 AM, Petr Jelinek wrote:
> On 22/03/15 10:35, Andres Freund wrote:
>>> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2015-03-21%2003%3A01%3A21
>>>
>>
>> That's the stuff looking like random memory that I talk about above...
>>
>
> If you look at it closely, it's actually not random memory. At least in
> the first 2 failing tests which are not obfuscated by aggregates on top
> of aggregates. It looks like first NumericDigit is ok and the second one
> is corrupted (there are only 2 NumericDigits in those numbers). Of
> course the conversion to Numeric is done from the end so it looks like
> only the last computation/pointer change/something stays ok while the
> rest got corrupted.

Would this mean the bug is most likely somewhere in 
int128_to_numericvar()? Maybe that version of gcc has a bug in some 
__int128 operator or I messed up the code there somehow.

Andreas




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Dmitry Voronin
Дата:
Сообщение: Re: New functions
Следующее
От: Andres Freund
Дата:
Сообщение: Re: Remove fsync ON/OFF as a visible option?