Re: Add min and max execute statement time in pg_stat_statement

On 17/02/15 02:57, Andrew Dunstan wrote:
>
> On 02/16/2015 08:48 PM, Petr Jelinek wrote:
>> On 17/02/15 01:57, Peter Geoghegan wrote:
>>> On Mon, Feb 16, 2015 at 4:44 PM, Petr Jelinek <petr@2ndquadrant.com>
>>> wrote:
>>>> We definitely want this feature, I wished to have this info many times.
>>>
>>> I would still like to see a benchmark.
>>>
>>>
>>
>> Average of 3 runs of read-only pgbench on my system all with
>> pg_stat_statement activated:
>> HEAD:  20631
>> SQRT:  20533
>> SQRTD: 20592
>>
>>
>
>
> So using sqrtd the cost is 0.18%. I think that's acceptable.
>

I think so too.

I found one more issue with the 1.2--1.3 upgrade script, the DROP 
FUNCTION pg_stat_statements(); should be DROP FUNCTION 
pg_stat_statements(bool); since in 1.2 the function identity has changed.


--  Petr Jelinek                  http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services