Re: Initdb-cs_CZ.WIN-1250 buildfarm failures

On 12/23/2014 07:14 AM, Tomas Vondra wrote:
> On 23.12.2014 09:19, Noah Misch wrote:
>> On Sat, Dec 20, 2014 at 07:28:33PM +0100, Tomas Vondra wrote:
>>> On 20.12.2014 19:05, Tom Lane wrote:
>>>> Locale cs_CZ.WIN-1250 is evidently marked with a codeset property of
>>>> "ANSI_X3.4-1968" (which means old-school US-ASCII).  That's certainly
>>>> wrong.  I believe the correct thing would be "CP1250".
>>> Yes. I fixed the locales and added the locales back to the client
>>> configuration.
>> Thanks.  These animals are now OK except on REL9_0_STABLE.  The log message of
>> commit 2dfa15d explains their ongoing 9.0 failures.  I recommend adding
>> --skip-steps=pl-install-check to their 9.0 invocations.  Dropping the affected
>> locales is another option, but we benefit from the rare encoding coverage more
>> than we benefit from the src/bin/pl coverage.
> OK, can do. Something like this in build-farm.conf should work, right?
>
> if ($branch eq 'REL9_0_STABLE')
> {
>      push(@{$conf{config_opts}},"--skip-steps=pl-install-check");
> }
>


No, config_opts is what's passed to configure. Try something like:
    if ($branch eq 'REL9_0_STABLE')    {        $skip_steps{'pl-install-check'} = 1;    }

cheers

andrew