Re: TABLESAMPLE patch

Hi,

v2 version of this patch is attached.


On 16/12/14 09:31, Petr Jelinek wrote:
> On 16/12/14 08:43, Jaime Casanova wrote:
>>
>> Sadly when the jsonb functions patch was committed a few oids where
>> used, so you should update the ones you are using. at least to make
>> the patch easier for testing.
>
> Will do.

Done.

>>
>> The test added for this failed, attached is the diff. i didn't looked
>> up why it failed
>>
>
> It isn't immediately obvious to me why, will look into it.

Fixed.

>
>> Finally, i created a view with a tablesample clause. i used the view
>> and the tablesample worked, then dumped and restored and the
>> tablesample clause went away... actually pg_get_viewdef() didn't see
>> it at all.
>>
>
> Yeah, as I mentioned in the submission the ruleutils support is not
> there yet, so that's expected.
>

Also fixed.

I also added proper costing/row estimation. I consider this patch
feature complete now, docs could still use improvement though.

--
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services