Re: Add shutdown_at_recovery_target option to recovery.conf

On 28/11/14 17:46, Alex Shulgin wrote:
>
> Christoph Berg <cb@df7cb.de> writes:
>
>> Re: Petr Jelinek 2014-11-25 <5474EFEA.2040000@2ndquadrant.com>
>>>> Patch committed.
>
> Before I go and rebase that recovery.conf -> GUC patch on top of
> this...  is it final?
>

I think so, perhaps sans the name mentioned below.

>>>
>>> Thanks!
>>
>> I'm a bit late to the party, but wouldn't
>>
>> recovery_target_action = ...
>>
>> have been a better name for this? It'd be in line with the other
>> recovery_target_* parameters, and also a bit shorter than the imho
>> somewhat ugly "action_at_recovery_target".
>
> FWIW, I too think that "recovery_target_action" is a better name.
>

I agree.

--  Petr Jelinek                  http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services