Re: Turning recovery.conf into GUCs

On 11/24/2014 02:00 PM, Alex Shulgin wrote:
> 
> Josh Berkus <josh@agliodbs.com> writes:
>>>
>>> only that you need to start in recovery mode to start replication
>>
>> Right, but my point is that having a trigger file *is not necessary for
>> replication, only for PITR* -- and maybe not necessary even for PITR.
>> That is, in a streaming replication configuration, having a
>> "standby_mode = on|off" parameter is 100% sufficient to control
>> replication with the small detail that "pg_ctl promote" needs to set it
>> in pg.auto.conf or conf.d.
>>
>> And, now, having given it some thought, I'm going to argue that it's not
>> required for PITR either, provided that we can use the auto.conf method.
>>
>> Before I go into my ideas, though, what does the current patch do
>> regarding non-replication PITR?
> 
> It removes that $PGDATA/standby.enable trigger file it relies on to
> start the PITR in the first place.

OK, and that's required for replication too?  I'm OK with that if it
gets the patch in.

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com