Re: make pg_controldata accept "-D dirname"

On 10/24/2014 11:36 AM, Michael Paquier wrote:
> On Thu, Sep 25, 2014 at 12:38 PM, Heikki Linnakangas <
> hlinnakangas@vmware.com> wrote:
>
>> On 09/24/2014 05:48 PM, Abhijit Menon-Sen wrote:
>>
>>> Updated patches attached.
>>>
>>
>> Thanks, applied some version of these.
>>
> This set of patches has been applied as b0d81ad but patch 0001 did not make
> it in, so pg_controldata is not yet able to accept -D:
> $ pg_controldata -D /foo/path
> pg_controldata: could not open file "-D/global/pg_control" for reading: No
> such file or directory
> $ pg_controldata /foo/path
> pg_controldata: could not open file "/foo/path/global/pg_control" for
> reading: No such file or directory

Argh, looks like I forgot the actual code changes required.

I just noticed that pg_controldata and pg_resetxlog don't check for 
extra arguments:

$ pg_resetxlog data fds sdf sdf
Transaction log reset

Fixed that too.

- Heikki