Re: Last Commitfest patches waiting review

On 09/27/2014 11:31 AM, Andres Freund wrote:
> On 2014-09-27 11:18:26 +0300, Heikki Linnakangas wrote:
>> pg_receivexlog: addition of --create/--drop to create/drop repslots
>> ---
>>
>> Magnus has promised to review this, but hasn't had the time for weeks. Does
>> anyone else want to pick this up? I'm OK to wait for Magnus to handle this -
>> I expect it to be a quick review and commit - but we should not hold up the
>> commitfest for this.
>
> I'll take that one, sometime next week, if Magnus hasn't gotten to it by then.

Thanks!

>> Compression of Full Page Writes
>> ---
>>
>> This has been a ridiculously long thread, with diversions into different
>> compression and CRC algorithms. Given that, the latest patch is surprisingly
>> small. I don't think this is going to get any better with further
>> discussion, and the patch looks OK at a quick glance, so I've now marked
>> this as "Ready for Committer".
>
> Did you like the patch? On a quick pass I wasn't very enthusiastic about
> it in its current state.

Now that I look at it closer, there's some ugly things there like 
putting the xl_compress field to XLogRecord. I guess I should post to 
the thread with more detailed comments.

- Heikki