Re: meson: Optionally disable installation of test modules
От | Peter Eisentraut |
---|---|
Тема | Re: meson: Optionally disable installation of test modules |
Дата | |
Msg-id | 53cbd1d2-b7f1-9a06-bfea-9b1f9be6b937@enterprisedb.com обсуждение исходный текст |
Ответ на | Re: meson: Optionally disable installation of test modules (Nazir Bilal Yavuz <byavuz81@gmail.com>) |
Ответы |
Re: meson: Optionally disable installation of test modules
Re: meson: Optionally disable installation of test modules |
Список | pgsql-hackers |
On 09.02.23 16:30, Nazir Bilal Yavuz wrote: > On 2/8/23 13:30, Peter Eisentraut wrote: >> >> If you feel that your patch is ready, please add it to the commit >> fest. I look forward to reviewing it. > > > Thanks! Commit fest entry link: https://commitfest.postgresql.org/42/4173/ I tested this a bit. It works fine. The approach makes sense to me. The install_additional_files script could be simplified a bit. You could use os.makedirs(dest, exist_ok=True) and avoid the error checking. I don't think any callers try to copy a directory source, so the shutil.copytree() stuff isn't necessary. Run pycodestyle over the script. And let's put the script into src/tools/ like the other support scripts.
В списке pgsql-hackers по дате отправления: