Re: JDBC build broken by commit 9f9019b

On 08/20/2014 11:43 AM, Craig Ringer wrote:
> Taking a look now. Odd - did I fail to push a final fixup before the merge?

Confirmed - yet I'm confused, as I'm pretty sure I remember Travis
passing with this, and just not updating the github issue. It was a
while ago.

Upon examining my local history, it looks like a case of "Oh, I should
also make this one minor fix that can't break anything just before I push".

Right.

I've pushed a fix.







BTW, I had to apply the attached diff to get the driver to build with my
ant 1.9.2, packaged in Fedora 20 .

The usual approach of popping maven-ant-tasks.jar in lib/ and running:

  ant -lib lib

or

  ant -lib lib/maven-ant-tasks.jar

was not effective, and still failed with:

$ ant -lib lib clean
Buildfile: /home/craig/projects/pgjdbc/build.xml

BUILD FAILED
/home/craig/projects/pgjdbc/build.xml:110: Problem: failed to create
task or type antlib:org.apache.maven.artifact.ant:dependencies
Cause: The name is undefined.
Action: Check the spelling.
Action: Check that any custom tasks/types have been declared.
Action: Check that any <presetdef>/<macrodef> declarations have taken place.
No types or tasks have been defined in this namespace yet

This appears to be an antlib declaration.
Action: Check that the implementing library exists in one of:
        -/usr/share/ant/lib
        -/home/craig/.ant/lib
        -a directory added on the command line with the -lib argument


... even though:


ant -lib lib clean -diagnostics

showed that maven-ant-tasks.jar was on the classpath, and unpacking the
jar showed that it contained the required antlib.xml that ant -v was
looking for:

[antlib:org.apache.maven.artifact.ant] Could not load definitions from
resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.


Weird. I don't think I had this issue last time around.

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services