SQL access to database attributes
От | Vik Fearing |
---|---|
Тема | SQL access to database attributes |
Дата | |
Msg-id | 538017D4.6060901@dalibo.com обсуждение исходный текст |
Ответы |
Re: SQL access to database attributes
|
Список | pgsql-hackers |
We try to tell our clients not to update the catalogs directly, but there are at least two instances where it's not possible to do otherwise (pg_database.datistemplate and .datallowconn). This patch aims to remedy that. For example, it is now possible to say ALTER DATABASE d ALLOW CONNECTIONS = false; and ALTER DATABASE d IS TEMPLATE = true; This syntax matches that of CONNECTION LIMIT but unfortunately required me to make ALLOW and CONNECTIONS unreserved keywords. I know we try not to do that but I didn't see any other way. The two new options are of course also available on CREATE DATABASE. There is a slight change in behavior with this patch in that previously one had to be superuser or have rolcatupdate appropriately set, and now the owner of the database is also allowed to change these settings. I believe this is for the better. It was suggested to me that these options should either error out if there are existing connections or terminate said connections. I don't agree with that because there is no harm in connecting to a template database (how else do you modify it?), and adding a reject rule in pg_hba.conf doesn't disconnect existing users so why should turning off ALLOW CONNECTIONS do it? As for regression tests, I couldn't figure out how to make CREATE/ALTER DATABASE play nice with make installcheck and so I haven't provided any. Other than that, I think this patch is complete and so I'm adding it the next commitfest. -- Vik
Вложения
В списке pgsql-hackers по дате отправления: