Re: Commit ad2a4ae causing more damages than fixes in regression tests

Hi Michael-san.

thank quick inspection.!

I've noticed it in some tests too. However, I think that it must be
fully considered the production environment psqlODBC have been supported
some versions. Therefore, I have a message level set to it.
What do you think?

again, I'm sorry not have a margin time....

Regards,
Hiroshi Saito

(2014/05/15 15:46), Michael Paquier wrote:
> Hi Saito-san,
>
> What is the purpose of commit ad2a4ae done yesterday? Regression tests
> are failing exactly because of that. I imagine that you are running
> your tests on a 9.2 server or older 9.3 because the NOTICE message
> showing PRIMARY KEY creation has been changed to DEBUG level in 9.3.
>
> For simplicity's sake, I think that we should make the regression
> tests only compatible with the latest versions of Postgres. We could
> still use some alternate output but what's the point except
> complicating the work of maintainers? Hence, I think that this change
> should be reverted. Or if you guys think that we need to make
> regression tests compatible down to 7.4 we should have alternate
> result outputs.
>
> I'd personally vote for reverting this commit to simplify maintenance
> as this project does not have stable branches.
>
> Regards,
>