Re: [HACKERS] plpgsql - additional extra checks

On 03/20/2018 05:36 AM, Pavel Stehule wrote:
> 
> 
> 2018-03-19 21:47 GMT+01:00 Tomas Vondra <tomas.vondra@2ndquadrant.com
> <mailto:tomas.vondra@2ndquadrant.com>>:
> 
>     Hi,
> 
>     I'm looking at the updated patch (plpgsql-extra-check-180316.patch), and
>     this time it applies and builds OK. The one thing I noticed is that the
>     documentation still uses the old wording for strict_multi_assignement:
> 
>     WARNING:  Number of evaluated fields does not match expected.
>     HINT:  strict_multi_assignement check of extra_warnings is active.
>     WARNING:  Number of evaluated fields does not match expected.
>     HINT:  strict_multi_assignement check of extra_warnings is active.
> 
>     This was reworded to "Number of source and target fields in assignment
>     does not match."
> 
> 
> fixed
> 

OK, thanks. PFA I've marked it as ready for committer.

I think the patch is solid code-wise, but I'm sure it might benefit e.g.
from a native speaker checking the wording of comments and messages.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services