[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #118

See <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/118/display/redirect?page=changes>

Changes:

[Dave Page] Add numerous missing checks to ensure objects really exist when we think

------------------------------------------
[...truncated 262.96 KB...]
Get materialized view under schema node ... ok
runTest (pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node ... ok
runTest (pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node ... ok
runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL ... ok
runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL ... ok
runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL ... ok
runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase)
Check Databases Node ... ok
runTest
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_add.ResourceGroupsAddTestCase)
Add resource groups ... ok
runTest
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_delete.ResourceGroupsDeleteTestCase)
Delete resource groups ... ok
runTest
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_put.ResourceGroupsPutTestCase)
Put resource groups ... ok
runTest
(pgadmin.browser.server_groups.servers.resource_groups.tests.tests_resource_groups_get.ResourceGroupsGetTestCase)
Get resource groups ... ok
runTest (pgadmin.browser.server_groups.servers.roles.tests.test_role_add.LoginRoleAddTestCase)
Check Role Node ... ok
runTest (pgadmin.browser.server_groups.servers.roles.tests.test_role_delete.LoginRoleDeleteTestCase)
Check Role Node ... ok
runTest (pgadmin.browser.server_groups.servers.roles.tests.test_role_get.LoginRoleGetTestCase)
Check Role Node ... ok
runTest (pgadmin.browser.server_groups.servers.roles.tests.test_role_put.LoginRolePutTestCase)
Check Role Node ... ok
runTest (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_add.TableSpaceAddTestCase)
Check Tablespace Node ... ok
runTest (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_delete.TableSpaceDeleteTestCase)
Check Tablespace Node ... ok
runTest (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_get.TablespaceGetTestCase)
Check Tablespace Node ... ok
runTest (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase)
Check Tablespace Node ... 2017-05-25 20:54:24,476: ERROR    pgadmin:    name 'sql' is not defined
Traceback (most recent call last):
  File
"<https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws/web/pgadmin/browser/server_groups/servers/tablespaces/__init__.py",>
line357, in update 
    if not isinstance(sql, (str, unicode)):
NameError: name 'sql' is not defined
pgAdmin 4 - Application Initialisation
======================================

NOTE: Configuring authentication for DESKTOP mode.
Please check output in file:
<https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws/web/regression/regression.log>

FAIL
runTest (pgadmin.browser.server_groups.servers.tests.test_check_recovery.TestCheckRecovery)
Test for check recovery ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_dependencies_sql.TestDependenciesSql)
Test dependencies SQL file ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_dependents_sql.TestDependentsSql)
Test dependencies SQL file ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_role_dependencies_sql.TestRoleDependenciesSql)
Test Role Dependencies SQL file ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_server_add.ServersAddTestCase)
Default Server Node url ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_server_delete.ServerDeleteTestCase)
Default Server Node url ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_server_get.ServersGetTestCase)
Default Server Node url ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_server_put.ServerUpdateTestCase)
Default Server Node url ... ok
runTest (pgadmin.browser.server_groups.tests.test_sg_get.SgNodeTestCase)
Check Server Group Node ... ok
runTest (pgadmin.utils.tests.test_versioned_template_loader.TestVersionedTemplateLoader)
Test versioned template loader ... ok
runTest (regression.python_test_utils.sql_template_test_base.SQLTemplateTestBase)
parent test class ... ok

======================================================================
FAIL: runTest (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase)
Check Tablespace Node
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"<https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_put.py",>
line58, in runTest 
    self.assertEquals(put_response.status_code, 200)
AssertionError: 500 != 200

----------------------------------------------------------------------
Ran 158 tests in 25.028s

FAILED (failures=1)

======================================================================
Test Result Summary
======================================================================

PostgreSQL 9.2:

    137 tests passed
    1 test failed:
        TableSpaceUpdateTestCase (Check Tablespace Node)
    20 tests skipped:
        PackageDeleteTestCase (Fetch Package Node URL)
        EventTriggerPutTestCase (Fetch Event Trigger Node URL)
        SynonymGetTestCase (Fetch synonym Node URL)
        SynonymPutTestCase (Fetch synonym Node URL)
        EventTriggerAddTestCase (Fetch Event Trigger Node URL)
        ResourceGroupsGetTestCase (Get resource groups)
        EventTriggerGetTestCase (Fetch Event Trigger Node URL)
        ResourceGroupsDeleteTestCase (Delete resource groups)
        ResourceGroupsPutTestCase (Put resource groups)
        PackageAddTestCase (Fetch Package Node URL)
        EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
        ViewsDeleteTestCase (Delete materialized view under schema node)
        ViewsUpdateTestCase (Update materialized view under schema node)
        SynonymDeleteTestCase (Fetch synonym Node URL)
        ViewsAddTestCase (Add materialized view under schema node)
        ViewsGetTestCase (Get materialized view under schema node)
        ResourceGroupsAddTestCase (Add resource groups)
        SynonymAddTestCase (Default Node URL)
        PackageGetTestCase (Fetch Package Node URL)
        PackagePutTestCase (Fetch Package Node URL)

PostgreSQL 9.4:

    145 tests passed
    1 test failed:
        TableSpaceUpdateTestCase (Check Tablespace Node)
    12 tests skipped:
        PackageDeleteTestCase (Fetch Package Node URL)
        SynonymGetTestCase (Fetch synonym Node URL)
        SynonymPutTestCase (Fetch synonym Node URL)
        PackageAddTestCase (Fetch Package Node URL)
        ResourceGroupsGetTestCase (Get resource groups)
        ResourceGroupsDeleteTestCase (Delete resource groups)
        ResourceGroupsPutTestCase (Put resource groups)
        SynonymDeleteTestCase (Fetch synonym Node URL)
        ResourceGroupsAddTestCase (Add resource groups)
        PackagePutTestCase (Fetch Package Node URL)
        PackageGetTestCase (Fetch Package Node URL)
        SynonymAddTestCase (Default Node URL)

EDB Postgres AS 9.6:

    157 tests passed
    1 test failed:
        TableSpaceUpdateTestCase (Check Tablespace Node)
    0 tests skipped

PostgreSQL 9.3:

    145 tests passed
    1 test failed:
        TableSpaceUpdateTestCase (Check Tablespace Node)
    12 tests skipped:
        PackageDeleteTestCase (Fetch Package Node URL)
        SynonymGetTestCase (Fetch synonym Node URL)
        SynonymPutTestCase (Fetch synonym Node URL)
        PackageAddTestCase (Fetch Package Node URL)
        ResourceGroupsGetTestCase (Get resource groups)
        ResourceGroupsDeleteTestCase (Delete resource groups)
        ResourceGroupsPutTestCase (Put resource groups)
        SynonymDeleteTestCase (Fetch synonym Node URL)
        ResourceGroupsAddTestCase (Add resource groups)
        PackagePutTestCase (Fetch Package Node URL)
        PackageGetTestCase (Fetch Package Node URL)
        SynonymAddTestCase (Default Node URL)

EDB Postgres AS 9.4:

    157 tests passed
    1 test failed:
        TableSpaceUpdateTestCase (Check Tablespace Node)
    0 tests skipped

PostgreSQL 9.5:

    145 tests passed
    1 test failed:
        TableSpaceUpdateTestCase (Check Tablespace Node)
    12 tests skipped:
        PackageDeleteTestCase (Fetch Package Node URL)
        SynonymGetTestCase (Fetch synonym Node URL)
        SynonymPutTestCase (Fetch synonym Node URL)
        PackageAddTestCase (Fetch Package Node URL)
        ResourceGroupsGetTestCase (Get resource groups)
        ResourceGroupsDeleteTestCase (Delete resource groups)
        ResourceGroupsPutTestCase (Put resource groups)
        SynonymDeleteTestCase (Fetch synonym Node URL)
        ResourceGroupsAddTestCase (Add resource groups)
        PackagePutTestCase (Fetch Package Node URL)
        PackageGetTestCase (Fetch Package Node URL)
        SynonymAddTestCase (Default Node URL)

EDB Postgres AS 9.5:

    157 tests passed
    1 test failed:
        TableSpaceUpdateTestCase (Check Tablespace Node)
    0 tests skipped

EDB Postgres AS 9.2:

    145 tests passed
    1 test failed:
        TableSpaceUpdateTestCase (Check Tablespace Node)
    12 tests skipped:
        EventTriggerPutTestCase (Fetch Event Trigger Node URL)
        ViewsUpdateTestCase (Update materialized view under schema node)
        EventTriggerAddTestCase (Fetch Event Trigger Node URL)
        ResourceGroupsGetTestCase (Get resource groups)
        EventTriggerGetTestCase (Fetch Event Trigger Node URL)
        ResourceGroupsDeleteTestCase (Delete resource groups)
        ResourceGroupsPutTestCase (Put resource groups)
        EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
        ViewsDeleteTestCase (Delete materialized view under schema node)
        ViewsAddTestCase (Add materialized view under schema node)
        ViewsGetTestCase (Get materialized view under schema node)
        ResourceGroupsAddTestCase (Add resource groups)

PostgreSQL 9.6:

    145 tests passed
    1 test failed:
        TableSpaceUpdateTestCase (Check Tablespace Node)
    12 tests skipped:
        PackageDeleteTestCase (Fetch Package Node URL)
        SynonymGetTestCase (Fetch synonym Node URL)
        SynonymPutTestCase (Fetch synonym Node URL)
        PackageAddTestCase (Fetch Package Node URL)
        ResourceGroupsGetTestCase (Get resource groups)
        ResourceGroupsDeleteTestCase (Delete resource groups)
        ResourceGroupsPutTestCase (Put resource groups)
        SynonymDeleteTestCase (Fetch synonym Node URL)
        ResourceGroupsAddTestCase (Add resource groups)
        PackagePutTestCase (Fetch Package Node URL)
        PackageGetTestCase (Fetch Package Node URL)
        SynonymAddTestCase (Default Node URL)

EDB Postgres AS 9.3:

    153 tests passed
    1 test failed:
        TableSpaceUpdateTestCase (Check Tablespace Node)
    4 tests skipped:
        ResourceGroupsAddTestCase (Add resource groups)
        ResourceGroupsDeleteTestCase (Delete resource groups)
        ResourceGroupsPutTestCase (Put resource groups)
        ResourceGroupsGetTestCase (Get resource groups)

======================================================================

ERROR: Error detected when running the Python tests.
ERROR: Error detected when running the Python tests.
Process leaked file descriptors. See http://wiki.jenkins-ci.org/display/JENKINS/Spawning+processes+from+build for more
information
Build step 'Execute shell' marked build as failure