Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions.

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions.
Дата
Msg-id 532CBD8C.9010801@vmware.com
обсуждение исходный текст
Ответ на Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions.  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-committers
On 03/21/2014 10:58 PM, Tom Lane wrote:
> I wrote:
>> I think the whole thing is too cute by half.  Why isn't it just
>
>> typedef enum GinLogicValue
>> {
>>      GIN_FALSE = 0,           /* item is present / matches */
>>      GIN_TRUE = 1,            /* item is not present / does not match */
>>      GIN_MAYBE = 2            /* don't know if item is present / don't know if
>>                                * matches */
>> } GinLogicValue;
>
> ... and now that I look at it a second time: *please* tell me the comments
> on the first two values should be swapped.  The API isn't really "false
> means a match", is it?

*facepalm*. Yes, the comments are backwards...

- Heikki


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: pgsql: Allow opclasses to provide tri-valued GIN consistent functions.
Следующее
От: Heikki Linnakangas
Дата:
Сообщение: pgsql: Fix build with LWLOCK_STATS or dtrace.