Re: Postgresql for cygwin - 3rd

On 25/01/2014 22:42, Marco Atzeri wrote:
> On 25/01/2014 19:23, Andrew Dunstan wrote:
>>
>> On 01/24/2014 07:50 AM, Marco Atzeri wrote:

>>
>>   * LDAP libraries - the way you have proposed surely isn't right. What
>>     we want is something more like this in the Makefile.global.in:
>>         ifeq ($(PORTNAME), cygwin)
>>         libpq_pgport += $(LDAP_LIBS_FE)
>>         endif
>
> I will test in this way. I have no preferance on
> the implemented solution.
>

your proposal builds fine.
----------------------------------------------------------------
--- origsrc/postgresql-9.3.2/src/Makefile.global.in     2013-12-02
21:57:48.000000000 +0100
+++ src/postgresql-9.3.2/src/Makefile.global.in 2014-01-25
22:46:36.484816700 +0100
@@ -508,6 +508,11 @@ ifeq ($(PORTNAME),win32)
  LIBS += -lws2_32 -lshfolder
  endif

+# missing for link on cygwin ?
+ifeq ($(PORTNAME),cygwin)
+libpq_pgport += $(LDAP_LIBS_FE)
+endif
+
  # Not really standard libc functions, used by the backend.
----------------------------------------------------------------

Of course no difference on test results, as expected

Attached full patch as I am currently testing on 9.3.2

Regards
Marco