Re: Incorrectly reporting config errors

On 01/21/2014 10:26 AM, Thom Brown wrote:
> Hi all,
>
> I'm getting a report of a config error when changing a config value
> that requires a restart:
>
> In postgresql.conf
>
> max_connections = 92
>
>
> (pg_ctl restart)
>
> postgres=# show max_connections ;
>   max_connections
> -----------------
>   92
> (1 row)
>
>
> (Edit postgresql.conf so that max_connections = 93)
>
> (pg_ctl reload)
>
> Now the log file contains:
>
> 2014-01-21 18:14:53 GMT [28718]: [4-1] user=,db=,client= LOG:
> received SIGHUP, reloading configuration files
> 2014-01-21 18:14:53 GMT [28718]: [5-1] user=,db=,client= LOG:
> parameter "max_connections" cannot be changed without restarting the
> server
> 2014-01-21 18:14:53 GMT [28718]: [6-1] user=,db=,client= LOG:
> configuration file "/home/thom/Development/data/postgresql.conf"
> contains errors; unaffected changes were applied
>
> It doesn't contain errors.  I changed the 92 to 93.  If I restart, it
> doesn't complain, and there's nothing in the log about the config
> anymore.
>
> This seems to be the case for any parameter with a postmaster context.
>
> I can understand why it logs the message about it not changing without
> a restart, but the other one seems like a bug.

You wanted a change in a value, the change did not occur, hence an error.

>
> I've tested this on 9.3 and 9.4devel.
>
> Thom
>
>


-- 
Adrian Klaver
adrian.klaver@gmail.com