Re: cleanup in code

On 01/04/2014 07:20 AM, Amit Kapila wrote:
> 1. compiling with msvc shows warning in relcache.c
> 1>e:\workspace\postgresql\master\postgresql\src\backend\utils\cache\relcache.c(3959):
> warning C4715: 'RelationGetIndexAttrBitmap' : not all control paths
> return a value
>
> Attached patch remove_msvc_warning.patch to remove above warning

Hmm, I thought we gave enough hints in the elog macro to tell the 
compiler that elog(ERROR) does no return, since commit 
b853eb97182079dcd30b4f52576bd5d6c275ee71. Have we not enabled that for MSVC?

> 2. It seems option K is not used in pg_dump:
>      while ((c = getopt_long(argc, argv,
> "abcCd:E:f:F:h:ij:K:n:N:oOp:RsS:t:T:U:vwWxZ:",
>                                       long_options, &optindex)) != -1)
>      I have checked both docs and code but didn't find the use of this option.
>      Am I missing something here?
>
>      Attached patch remove_redundant_option_K_pgdump.patch to remove this option
>      from code.

Huh. That was added by my commit that added --dbname option, by 
accident. Removed, thanks.

- Heikki