Re: GIN improvements part 1: additional information

On 11/28/2013 09:19 AM, Alexander Korotkov wrote:
> On Wed, Nov 27, 2013 at 1:14 AM, Heikki Linnakangas <hlinnakangas@vmware.com
>> wrote:
>
>> On 11/26/13 15:34, Alexander Korotkov wrote:
>>
>>> What's your plans about GIN now? I tried to rebase packed posting lists
>>> with head. But I found that you've changed interface of placeToPage
>>> function. That's conflicts with packed posting lists, because
>>> dataPlaceToPageLeaf needs not only offset number to describe place to
>>> insert item pointer. Do you like to commit rework of handling GIN
>>> incomplete splits before?
>>
>> Yeah, I'm planning to get back to this patch after committing the
>> incomplete splits patch. I think the refactoring of the WAL-logging that I
>> did in that patch will simplify this patch, too. I'll take a look at
>> Michael's latest comments on the incomplete splits patch tomorrow, so I
>> should get back to this on Thursday or Friday.
>
> Should I try to rebase this patch now or you plan to do it yourself? Some
> changes like "void *insertdata" argument make me think you have some
> particular plan to rebase this patch, but I didn't get it exactly.

Here's rebased version. I'll continue reviewing it now..

- Heikki