Re: b21de4e7b32f868a23bdc5507898d36cbe146164 seems to be two bricks shy of a load

On 11/21/2013 05:52 AM, David Rowley wrote:
> I'm not quite sure why nobody else seems to be complaining, but the 
> changes to type.h in this commit seems to have broken things little.
>
> In the visual studios build I'm getting:
>
>   src\interfaces\ecpg\preproc\preproc.y(84): error C2065: 'ET_FATAL' : 
> undeclared identifier [D:\Postgres\b\ecpg.vcxproj]
>   src\interfaces\ecpg\preproc\preproc.y(84): error C2051: case 
> expression not constant [D:\Postgres\b\ecpg.vcxproj]
>   src\interfaces\ecpg\preproc\preproc.y(102): error C2065: 'ET_FATAL' 
> : undeclared identifier [D:\Postgres\b\ecpg.vcxproj]
>   src\interfaces\ecpg\preproc\preproc.y(102): error C2051: case 
> expression not constant [D:\Postgres\b\ecpg.vcxproj]
>   src\interfaces\ecpg\preproc\preproc.y(14664): error C2065: 
> 'ET_FATAL' : undeclared identifier [D:\Postgres\b\ecpg.vcxproj]
>
> Which I'm guessing is something to do with:
>
> --- a/src/interfaces/ecpg/preproc/type.h 
>
<http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/interfaces/ecpg/preproc/type.h;h=b7768fd66146e16547f385d30272e2a42e4d6832;hb=b7768fd66146e16547f385d30272e2a42e4d6832>
> +++ b/src/interfaces/ecpg/preproc/type.h 
>
<http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/interfaces/ecpg/preproc/type.h;h=cd0d1da8c4a1a641acd9f6b6b7dfa88e7241394d;hb=cd0d1da8c4a1a641acd9f6b6b7dfa88e7241394d>
> @@ -186,7 
>
<http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/interfaces/ecpg/preproc/type.h;h=b7768fd66146e16547f385d30272e2a42e4d6832;hb=b7768fd66146e16547f385d30272e2a42e4d6832#l186>

> +186,7 
>
<http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/interfaces/ecpg/preproc/type.h;h=cd0d1da8c4a1a641acd9f6b6b7dfa88e7241394d;hb=cd0d1da8c4a1a641acd9f6b6b7dfa88e7241394d#l186>

> @@ struct assignment
>  enum errortype
>  {
> -   ET_WARNING, ET_ERROR, ET_FATAL
> +   ET_WARNING, ET_ERROR
>  };
>
>
>


(Note, please use shortened commit hashes in your subjects - the leading 
7 hex digits of the hash are usually sufficient to identify it.)


The buildfarm animals using MSVC are not exhibiting this problem. When 
you see something like this, the buildfarm is probably the first place 
you should look.

cheers

andrew