Re: pg_filedump 9.3: checksums (and a few other fixes)

Hi,

I have reviewed this patch as a CF reviewer.

(2013/06/27 4:07), Jeff Davis wrote:
> On Mon, 2013-06-24 at 20:34 -0400, Josh Kupershmidt wrote:
>> This patch is in the current CommitFest, does it still need to be
>> reviewed? If so, I notice that the version in pgfoundry's CVS is
>> rather different than the version the patch seems to have been built
>> against (presumably the pg_filedump-9.2.0.tar.gz release), and
>> conflicts in several places with cvs tip.
>
> Rebased against CVS tip; attached.

It looks fine, but I have one question here.

When I run pg_filedump with -k against a database cluster which
does not support checksums, pg_filedump produced checksum error as
following. Is this expected or acceptable?

-----------------------------------------------------------------
*******************************************************************
* PostgreSQL File/Block Formatted Dump Utility - Version 9.3.0
*
* File: /tmp/pgsql/data/base/16384/16397
* Options used: -k
*
* Dump created on: Sat Jul  6 10:32:15 2013
*******************************************************************

Block    0 ********************************************************
<Header> -----
  Block Offset: 0x00000000         Offsets: Lower     268 (0x010c)
  Block: Size 8192  Version    4            Upper     384 (0x0180)
  LSN:  logid      0 recoff 0x00000000      Special  8192 (0x2000)
  Items:   61                      Free Space:  116
  Checksum: 0x0000  Prune XID: 0x00000000  Flags: 0x0000 ()
  Length (including item array): 268

  Error: checksum failure: calculated 0xf797.

<Data> ------
  Item   1 -- Length:  121  Offset: 8064 (0x1f80)  Flags: NORMAL
  Item   2 -- Length:  121  Offset: 7936 (0x1f00)  Flags: NORMAL
  Item   3 -- Length:  121  Offset: 7808 (0x1e80)  Flags: NORMAL
-----------------------------------------------------------------

Please check attached script to reproduce it.

Also, I have update the help message and README.
Please check attached patch.

Regards,
--
Satoshi Nagayasu <snaga@uptime.jp>
Uptime Technologies, LLC. http://www.uptime.jp