Re: pgsql: Improve support for building PGXS modules with VPATH.

On 07/01/2013 02:40 PM, Andrew Dunstan wrote:
>
> On 07/01/2013 01:39 PM, Alvaro Herrera wrote:
>> Andrew Dunstan wrote:
>>> Improve support for building PGXS modules with VPATH.
>>>
>>> A VPATH build will be performed when the module's make file path is not
>>> the current directory or when USE_VPATH is set.
>> So what's the USE_VPATH thing for?  I mean, can't you just use VPATH
>> instead?
>>
>
> Well, I was distinguishing between things set by the Makefile and
> things set outisde, but you're probably right. I'll test it and tweak.
>
>


Actually, when I try to get rid of it I get issues with srcdir being
recursively defined.

And in fact, VPATH is defined by Makefile.global when the Postgres build
is a VPATH build, and unrelated to the module's build setup.

So I think it's probably best to leave this as it is unless you can
suggest an easy fix.

cheers

andrew