Re: [HACKERS] Show INHERIT in \du
От | Tom Lane |
---|---|
Тема | Re: [HACKERS] Show INHERIT in \du |
Дата | |
Msg-id | 5164.1206376868@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: [HACKERS] Show INHERIT in \du ("Brendan Jurd" <direvus@gmail.com>) |
Ответы |
Re: [HACKERS] Show INHERIT in \du
|
Список | pgsql-patches |
"Brendan Jurd" <direvus@gmail.com> writes: > I've had a chance to look at this now, and although it certainly does > seem workable, there's a lot of duplication of code that I feel uneasy > about. describeOneTableDetails essentially already duplicates the > table buildling code in printQuery, so I would be creating a third > copy of the same logic. > This makes me wonder whether print.c could offer something a bit more > helpful to callers wishing to DIY a table; we could have a > table-building struct with methods like addHeader and addCell. > What do you think? Overkill, or worthy pursuit? Once you have two occurrences of a pattern, it's reasonable to assume there will be more later. +1 for building a little bit of infrastructure. regards, tom lane
В списке pgsql-patches по дате отправления: