Re: backward incompatible pg_basebackup and pg_receivexlog

On 25.03.2013 11:23, Heikki Linnakangas wrote:
> On 19.03.2013 13:49, Magnus Hagander wrote:
>> On Tue, Mar 19, 2013 at 11:39 AM, Heikki Linnakangas
>> <hlinnakangas@vmware.com> wrote:
>>> On 19.03.2013 04:42, Peter Eisentraut wrote:
>>>>
>>>> Also, using the old tools against new server versions either behaves
>>>> funny or silently appears to work, both of which might be a problem.
>>>
>>> Hmm, it would be good to fix that. I wonder how, though. The most
>>> straightforward way would be to add an explicit version check in the
>>> clients, in backbranches. That would give a nice error message, but that
>>> would only help with new minor versions.
>>
>> Still better to do it in a backbranch, than not at all. At least we
>> are then nicer to the ones that do keep up with upgrades, which we
>> recommend they do...
>
> Ok, here are patches for 9.1, 9.2 and master, to add explicit version
> checks. Each branch has its own quirks. A 9.1 client should still work
> with a 9.2 server, because we don't want to break things in a minor
> version that used to accidentally work, even if it was never explicitly
> supported. In master, I tweaked pg_basebackup so that it still works
> with older servers if you don't use the "-X stream" option. The changes
> to the streaming protocol only affected "-X stream".
>
> This doesn't yet add the "streaming protocol version number" that was
> discussed.

Committed this.. Will work on the additional version number.

- Heikki