Re: unified vs context diffs (was Re: Strange Windows problem, lock_timeout test request)

2013-02-25 15:25 keltezéssel, Tom Lane írta:
> Stephen Frost <sfrost@snowman.net> writes:
>> * Robert Haas (robertmhaas@gmail.com) wrote:
>>> True, but I'm with Heikki: it's a pedantic and unhelpful guideline.
>> Then let's change it, drop the preference, and update the documentation.
> I think we should drop the hard requirement for context-format, and
> instead say that it must not be plain (context-free) diff, since that
> clearly *is* a hard requirement.
>
> However, I liked the upthread suggestion (I think it was from Heikki)
> that we recommend that submitters actually take a moment to think about
> which format is more readable for their particular patch.   Readability
> is important not only to help people who just give the patch a quick
> eyeball, but also to help the inevitable situations where hunks have
> to be applied by hand because the underlying code has changed.  The
> less readable the patch, the more likely an error in doing that.

+1

I think the readability is mostly the de-facto threshold. Considering
that quite a few plain "git diff" patches were committed during this CF
but those were readable in that format, even biggies like "teach
receivexlog to switch timelines" which (I just browsed it) had parts
that rewrote code in a way that the diff had pieces with different
indentation intermixed. This can constitute to being unreadable
at times but it also depends on the reader.

Best regards,
Zoltán Böszörményi

--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de     http://www.postgresql.at/