Re: logical changeset generation v4

On 15/01/13 17:37, Mark Kirkwood wrote:
> On 15/01/13 14:38, Andres Freund wrote:
>> Hi everyone,
>>
>> Here is the newest version of logical changeset generation.
>>
>>
>
>
>
> I'm quite interested in this feature - so tried applying the 19 
> patches to the latest 9.3 checkout. Patch and compile are good.
>
> However portals seem busted:
>
> bench=# BEGIN;
> BEGIN
> bench=# DECLARE c1 CURSOR FOR SELECT * FROM pgbench_accounts;
> DECLARE CURSOR
> bench=# FETCH 2 FROM c1;
>  aid | bid | abalance | filler
>
> -----+-----+----------+--------------------------------------------------------- 
>
> -----------------------------
>    1 |   1 |        0 |
>
>    2 |   1 |        0 |
>
> (2 rows)
>
> bench=# DELETE FROM pgbench_accounts WHERE CURRENT OF c1;
> The connection to the server was lost. Attempting reset: Failed.
>

Sorry - forgot to add: assert and debug build, and it is an assertion 
failure that is being picked up:

TRAP: FailedAssertion("!(htup->t_tableOid != ((Oid) 0))", File: 
"tqual.c", Line: 940)