Re: pg_upgrade diffs on WIndows

On 09/04/2012 03:09 PM, Andrew Dunstan wrote:
> I realized this morning that I might have been a bit cavalier in using
> dos2unix to smooth away differences in the dumpfiles produced by
> pg_upgrade. Attached is a dump of the diff if this isn't done,  with
> Carriage Returns printed as '*' to make them visible. As can be seen,
> in function bodies dump2 has the Carriage Returns doubled. I have not
> had time to delve into how this comes about, and I need to attend to
> some income-producing activity for a bit, but I'd like to get it
> cleaned up ASAP. We are under the hammer for 9.2, so any help other
> people can give on this would be appreciated.
>


Actually, I have the answer - it's quite simple. We just need to open
the output files in binary mode when we split the dumpall file. The
attached patch fixes it. I think we should backpatch the first part to 9.0.

cheers

andrew