Re: [INTERFACES] Re: [PATCHES] Re: Fixes and enhancements to JDBC driver(take 2)

At 09:30 02/02/01 -0500, Richard Bullington-McGuire wrote:
>On Fri, 2 Feb 2001, Peter T Mount wrote:
>
> > > What is the final resolution of this for 7.1?  I noticed that you have
> > > essentially commented out the byte array pooling code in current
> > > sources.  Given that 7.1 is rapidly coming to a close, is this
> > > something
> > > that is expected to get fixed and reenabled for 7.1, or is this going
> > > to wait for 7.2.
> >
> > I commented it out to make sure that when 7.1 was released the driver
> > would at least work (with it enabled we would have one broken driver).
>
>At Microstate, we fixed the byte pooling code when it was still in
>PG_Stream. We patched this and submitted our patch to pgsql-patches, and
>it was accepted.  It did have some nasty off-by-one errors. It does not
>look like the fixes we did made it into the new, separate
>org.postgresql.core.BytePoolDim[12] classes.


Hmmm, should have as I remember puting your fixes in. I remember this as I
had to apply the patch manually as I did it while moving the code out of
PG_Stream. I'll double check.



>We've been using this code on an application with many tens of thousands
>of queries per day for more than a month without any problems.
>
>I've attached the production PG_Stream.java class that we've been using.


Thanks.