Re: [PATCH] Allow multiple recursive self-references
От | Peter Eisentraut |
---|---|
Тема | Re: [PATCH] Allow multiple recursive self-references |
Дата | |
Msg-id | 4fd5d5f3-e662-868b-229d-40030a487fa4@enterprisedb.com обсуждение исходный текст |
Ответ на | Re: [PATCH] Allow multiple recursive self-references (Denis Hirn <denis.hirn@uni-tuebingen.de>) |
Ответы |
Re: [PATCH] Allow multiple recursive self-references
|
Список | pgsql-hackers |
On 20.07.21 13:15, Denis Hirn wrote: >> In the next version of the patch, would you be so kind as to include >> updated documentation of the feature and at least one regression test >> of same? > > As requested, this new version of the patch contains regression tests and documentation. The tests fail when you build with assertions enabled (configure --enable-cassert). Some quick style comments: DocBook content should use 1-space indentation (not 2 spaces). Typo?: /* we'll see this later */ -> "set" Opening brace after "if" should be on new line. (See existing code.) Also, there should be a space after "if". These casts appear to be unnecessary: if((Node *) stmt->larg != NULL && (Node *) stmt->rarg != NULL)
В списке pgsql-hackers по дате отправления: