Re: [HACKERS] assorted code cleanup
От | Peter Eisentraut |
---|---|
Тема | Re: [HACKERS] assorted code cleanup |
Дата | |
Msg-id | 4cf1f89b-10d2-46b8-bd52-ed48e1ceb462@2ndquadrant.com обсуждение исходный текст |
Ответ на | Re: [HACKERS] assorted code cleanup (Ryan Murphy <ryanfmurphy@gmail.com>) |
Список | pgsql-hackers |
On 8/29/17 03:32, Ryan Murphy wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation: tested, passed > > I've reviewed the code changes, and it's pretty clear to me that they clean things up a bit while not changing any behavior. They simplify things in a way that make the code more comprehensible. I've run all the tests and they behave thesame way as they did before the patch. I also trying manually playing around the the function in question, `metaphone`,and it seems to behave the same as before. > > I think it's ready to commit! > > The new status of this patch is: Ready for Committer Pushed, except the one with the function pointers, which some people didn't like. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
В списке pgsql-hackers по дате отправления: