Re: pgsql: Doc: remove some long-obsolete information frominstallation.sgm

On 2019-09-01 23:34, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>>> Doc: remove some long-obsolete information from installation.sgml.
> 
>> - It is a fully native build and uses no additional software like
>> - MinGW.  A ready-made installer is available on the main
>> - PostgreSQL web site.
>> + The Visual C++ build is recommended, as it is fully native and uses no
>> + additional software like MinGW.  A ready-made installer is available on
>> + the main PostgreSQL web site.
> 
>> Is this correct?  MinGW builds are also native builds.  The old wording
>> was shaky but the new wording (inserting "... is recommended, as ...")
>> makes it sound like that there is something wrong with the MinGW build
>> compared to the MSVC build.
> 
> So did the old wording, it seemed to me.  I'm happy to remove the sentence
> altogether if there's no reason to be pushing people away from MinGW.
> Should we also rethink the sentence I added at the top of the chapter,
> pointing Windows people to chapter 17?

Yeah, I suggest this:

diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml
index 1f2f7d9957..6e79133681 100644
--- a/doc/src/sgml/installation.sgml
+++ b/doc/src/sgml/installation.sgml
@@ -21,10 +21,6 @@ <title>Installation from Source Code</title>
   distribution.  If you are installing a pre-packaged distribution,
   such as an RPM or Debian package, ignore this chapter
   and read the packager's instructions instead.
-  Also, this chapter does not describe the preferred way to install
-  <productname>PostgreSQL</productname> on Microsoft
-  Windows<phrase condition="standalone-ignore"> (for that, see
-  <xref linkend="install-windows"/>)</phrase>.
  </para>

  <sect1 id="install-short">
@@ -2484,9 +2480,7 @@ <title>MinGW/Native Windows</title>
     The MinGW build procedure uses the normal build system described in
     this chapter; the Visual C++ build works completely differently
     and is described in <xref linkend="install-windows"/>.
-    The Visual C++ build is recommended, as it is fully native and uses no
-    additional software like MinGW.  A ready-made installer is available on
-    the main PostgreSQL web site.
+    A ready-made installer is available on the main PostgreSQL web site.
    </para>

    <para>

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services