Re: WIP: Covering + unique indexes.

Thank you, pushed

Peter Geoghegan wrote:
> On Wed, Apr 18, 2018 at 10:47 PM, Teodor Sigaev <teodor@sigaev.ru> wrote:
>> Thank you, pushed.
> 
> Thanks.
> 
> I saw another preexisting issue, this time one that has been around
> since 2007. Commit bc292937 forgot to remove a comment above
> _bt_insertonpg() (the 'afteritem' stuff ended up being moved to the
> bottom of _bt_findinsertloc(), where it remains today). The attached
> patch fixes this, and in passing mentions the fact that
> _bt_insertonpg() only performs retail insertions, and specifically
> never inserts high key items.
> 
> I don't think it's necessary to add something about negative infinity
> items to the same comment block. While it's true that _bt_insertonpg()
> cannot truncate downlinks to make new minus infinity items, I see that
> as a narrower issue.
> 

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/