Re: patch for a locale-specific bug in regression tests (REL9_1_STABLE)

On 7.3.2012 21:39, Robert Haas wrote:
> On Wed, Mar 7, 2012 at 3:08 PM, Tomas Vondra <tv@fuzzy.cz> wrote:
>> On 7.3.2012 17:56, Robert Haas wrote:
>>> On Tue, Mar 6, 2012 at 1:59 PM, Tomas Vondra <tv@fuzzy.cz> wrote:
>>>> I've noticed a locale-specific bug in regression tests, I discovered
>>>> thanks to the new "magpie" buildfarm member (testing "cs_CZ" locale).
>>>> The problem is in "foreign_data" where the output is sorted by a column,
>>>> and "cs_CZ" behaves differently from "C" and "en_US".
>>>>
>>>> More precisely, in "C" it's true that ('s4' < 'sc') but that's not true
>>>> in cs_CZ (and supposedly some other locales).
>>>>
>>>> I've fixed this by replacing 'sc' with 't0' which seems to fix the
>>>> ordering (and should work with other locales too). See the patch attached.
>>>
>>> This was fixed on master in commit
>>> 3e9a2672d25aed15ae6b4a09decbd8927d069868, but that picked the name s0
>>> rather than t0.  I suggest we make the same naming decision in the
>>> back-branch to avoid future confusion...
>>
>> Yes, that's a better solution - I haven't noticed that commit. Should I
>> prepare a modified patch or is it possible to apply the fix from master
>> to this branch?
>
> I tried to cherry-pick it, but there were conflicts, so I guess
> someone will need to go through and adjust.  It's probably only 10
> minutes work, but if you don't mind doing it, I'd be grateful.

Ok, so here's a fixed patch. I haven't used the 3e9a2672 commit
directly, because there seem to be additional changes. I've simply
renamed the 'sc' to 's0' and fixed the differences in output.

Tomas