Re: SSI work for 9.1
От | Heikki Linnakangas |
---|---|
Тема | Re: SSI work for 9.1 |
Дата | |
Msg-id | 4DF87706.9030506@enterprisedb.com обсуждение исходный текст |
Ответ на | Re: SSI work for 9.1 ("Kevin Grittner" <Kevin.Grittner@wicourts.gov>) |
Ответы |
Re: SSI work for 9.1
|
Список | pgsql-hackers |
On 14.06.2011 17:57, Kevin Grittner wrote: > Heikki Linnakangas<heikki.linnakangas@enterprisedb.com> wrote: > >> I did some further changes, refactoring SkipSerialization so that >> it's hopefully more readable, and added a comment about the >> side-effects. See attached. Let me know if I'm missing something. > > I do think the changes improve readability. I don't see anything > missing, but there's something we can drop. Now that you've split > the read and write tests, this part can be dropped from the > SerializationNeededForWrite function: > > + > + /* Check if we have just become "RO-safe". */ > + if (SxactIsROSafe(MySerializableXact)) > + { > + ReleasePredicateLocks(false); > + return false; > + } > > If it's doing a write, it can't be a read-only transaction.... Ah, good point. Committed with that removed. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com
В списке pgsql-hackers по дате отправления: