Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token

Le 13/03/2011 09:46, Dave Page a écrit :
> On Sun, Mar 13, 2011 at 1:52 AM, Peter Geoghegan <peter@2ndquadrant.com> wrote:
>> On 12 March 2011 19:13, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>>> Maybe a stupid question but what is the ! in the variable name
>>> (ex_hash_setop_except_png!_data)?
>>
>> There's no good reason. It isn't a valid identifier name.
>>
>> Whatever preprocessor generates ex_hash_setop_except.pngc and other
>> files like it is broken.
>>
>> Take a look at this code, at line 205 of same, that clearly illustrates this:
>>
>> static wxIcon *ex_hash_setop_except_png!_ico()
>
> Line 205 here reads:
>
> static wxIcon *ex_hash_setop_except_png_ico()
>
> On Mac and Windows (and Linux worked last time I tried it). Can you
> see what's causing the issue for you in the preprorocessor?
>

So I worked a bit on this issue tonight. I think you didn't allocate
enough memory for filename. See the patch attached. With this patch, it
works OK for me. I'm wondering if the patch should also do +1 on the
other calloc calls. Any ideas on this?

Can you check that it still works on Windows and Mac OS X with this patch?


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com