Re: Uncalled CREATE OR REPLACE VIEW in privileges dialog

Hi Erwin,

Le 04/01/2011 21:24, Erwin Brandstetter a écrit :
> [...]
> My best wishes for 2011 to the pgAdmin team! :)
>

Best wishes for you too :)

> Testing v.1.12.2 (Dec 13 2010) on Windows XP Pro, Server PostgreSQL
> 8.4.5 on Debian Lenny.
> I found some weirdness in the privileges dialog for VIEWs.
>
> On changing any privileges via dialog, the VIEW itself gets CREATE OR
> REPLACEd in addition. That's uncalled for.
> As long as the used SQL is free of mistakes, this will probably go
> unnoticed by most. It is still a waste of CPU cycles - and a problem
> waiting to happen.
> Reproducibly every time.
> The matching dialog for TABLEs seems ok.
> Problem is also present in v.1.10
>
> I have created a track ticket accordingly:  #296
> I skipped the e-mail to the list and just filed the ticket in trac with
> a couple of issues recently as I did not feel the need for more details.
> I hope that is acceptable protocol ...
>

Sure. I would love to get such good report every time a user finds a bug :)

Anyway, found the issue, fixed it, and pushed the commits.

Thanks again.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com