Re: [PATCH] V3: Idle in transaction cancellation

Andres Freund wrote: <blockquote cite="mid:201012022236.52551.andres@anarazel.de" type="cite"><pre wrap="">On Thursday
02December 2010 22:21:37 Alvaro Herrera wrote: </pre><blockquote type="cite"><pre wrap="">Excerpts from Andres Freund's
messageof sáb oct 30 05:49:21 -0300 2010:   </pre><blockquote type="cite"><pre wrap="">Ill set this up for the next
commitfest,I don't think I can do much
 
more  without further input.     </pre></blockquote><pre wrap="">Are you reserving about 20 bits for levels, and 12 for
flags? Given the
 
relatively scarce growth of levels, I think we could live with about 6
or 7 bits for level, rest for flags.   </pre></blockquote><pre wrap="">The number I picked was absolutely arbitrary I
admit.Neither did I think it 
 
would be likely to see more levels, nor did I forsee many flags, so I just 
chose some number I liked in that certain moment ;-) </pre></blockquote><br /> This bit of detail seems to have died
downwithout being resolved; bumping it to add a reminder about that.<br /><br /> I count four issues of various sizes
leftwith this patch right now:<br /><br /> 1) This levels bit<br /> 2) Can the approach used be simplified or the code
madecleaner?<br /> 3) What is the interaction with Hot Standby error handling?<br /> 4) The usual code formatting
nitpicking,Kevin mentioned braces being an issue<br /><br /> Robert is already thinking about (2); I'll keep an eye out
forsomeone who can test (3) now that it's been identified as a concern; and the other two are pretty small details once
thoseare crossed.  I don't see this as being ready to commit just yet though, so I don't see this going anywhere other
thanreturned for now; will mark it as such.  Hopefully this will gather enough additional review to continue moving
forwardnow that the main issues are identified.<br /><br /><pre class="moz-signature" cols="72">-- 
 
Greg Smith   2ndQuadrant US    <a class="moz-txt-link-abbreviated"
href="mailto:greg@2ndQuadrant.com">greg@2ndQuadrant.com</a>  Baltimore, MD
 
PostgreSQL Training, Services and Support        <a class="moz-txt-link-abbreviated"
href="http://www.2ndQuadrant.us">www.2ndQuadrant.us</a>
"PostgreSQL 9.0 High Performance": <a class="moz-txt-link-freetext"
href="http://www.2ndQuadrant.com/books">http://www.2ndQuadrant.com/books</a>
</pre>