Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

Fujii Masao wrote:
> On Wed, Apr 28, 2010 at 4:43 PM, Heikki Linnakangas
> <heikki.linnakangas@enterprisedb.com> wrote:
>> Ok, did that. Here's an updated patch:
> 
>> +        During recovery, specifies whether or not you can connect and run
>> +        queries to enable <xref linkend="hot-standby">. The default value is
>> +        <literal>on</literal>.
>> +        This parameter can only be set at server start. It is ignored when
>> +        not in standby mode.
> 
> In the patch, I was not able to find any change which ignores
> recovery_connections when standby_mode is OFF.
> 
> And that change spoils the combination of pg_standby and HS?
> We drop the support for it?

That sentence is poorly worded, recovery_connections works in archive
recovery too (and with pg_standby). I'll rephrase that to "It only has
effect during archive recovery or standby mode."

>> * renamed wal_mode to wal_level
> 
> We should replace "mode" with "level" in the document of wal_level
> parameter as follows?
> 
> ...

Yep.

Thanks!

--  Heikki Linnakangas EnterpriseDB   http://www.enterprisedb.com