Re: point_ops for GiST
От | Teodor Sigaev |
---|---|
Тема | Re: point_ops for GiST |
Дата | |
Msg-id | 4B4B667E.2010305@sigaev.ru обсуждение исходный текст |
Ответ на | Re: point_ops for GiST (Robert Haas <robertmhaas@gmail.com>) |
Ответы |
Re: point_ops for GiST
|
Список | pgsql-hackers |
> I have reviewed this patch and it looks good to me. The only > substantive question I have is why gist_point_consistent() uses a > different coding pattern for the box case than it does for the polygon > and circle cases? It's not obvious to me on the face of it why these > aren't consistent. gist_circle_consistent/gist_poly_consistent set recheck flag to true because corresponding index contains only bounding box of indexed values (circle/polygon). gist_point_consistent could do an exact check. Will add a coments. > Beyond that, I have a variety of minor whitespace and commenting > suggestions, so I am attaching an updated version of the patch as well Agree with your changes. Suppose, there is no objection to commit it? -- Teodor Sigaev E-mail: teodor@sigaev.ru WWW: http://www.sigaev.ru/
В списке pgsql-hackers по дате отправления: