Re: Feature patch 1 for plperl [PATCH]
От | Andrew Dunstan |
---|---|
Тема | Re: Feature patch 1 for plperl [PATCH] |
Дата | |
Msg-id | 4B491BD4.2080204@dunslane.net обсуждение исходный текст |
Ответ на | Re: Feature patch 1 for plperl [PATCH] (Peter Eisentraut <peter_e@gmx.net>) |
Ответы |
Re: Feature patch 1 for plperl [PATCH]
|
Список | pgsql-hackers |
Peter Eisentraut wrote: > On fre, 2010-01-08 at 15:01 +0000, Tim Bunce wrote: > >> I didn't get any significant feedback from the earlier draft so here's >> the finished 'feature patch 1' for plperl. >> > > I think it would help if you could split this up into about 6 to 10 > single-feature patches. > I think that's a bit excessive. I'd suggest three patches: * the new utility functions (quote_literal, decode_bytea etc.) These should be fairly uncontroversial, but accountfor a large part of the patch volume. * the code relating to library load, interpreter initialization and termination * the remainder (function naming, better error checking, enabling use/require if a lib is already loaded,cleanup and optimization) We could ask Tim to break up the last, but they are all fairly small items, and I at least wouldn't be bothered by having them combined. And having to handle 6 to 10 patches all hitting the same body of code doesn't sound terrible pleasant either. cheers andrew
В списке pgsql-hackers по дате отправления: