Tom Lane wrote:
> Applied with a moderate amount of editorialization.
Thank you!
> Notably, I didn't
> like what you'd done with the EvalPlanQual stuff, and after a bit of
> reflection decided that the right thing was to teach EvalPlanQual to
> execute just the desired subplan.
I didn't really like that either but I didn't have any good ideas. This
is a lot better.
> Also, I put back the marking of
> the ModifyTuple node with its target relations, which you'd removed
> in the v4 patch --- I'm convinced that that will be necessary in some
> form or other later, so taking it out now seemed like moving backward.
Ok.
> 2. Move actual execution of (non-deferred) AFTER triggers inside
> ModifyTuple. This might be a good idea in order to have the most
> consistent results for a series of WITH queries, but I'm not sure.
This definitely seems like the best option to me.
Regards,
Marko Tiikkaja