Re: Hot Standby on git

Simon Riggs wrote:
> @@ -7061,6 +7061,15 @@ ShutdownXLOG(int code, Datum arg)
>     else
>     {
>         /*
> +        * Take a snapshot of running transactions and write this to WAL.
> +        * This allows us to reconstruct the state of running transactions
> +        * during archive recovery, if required. We do this even if we are
> +        * not archiving, to allow a cold physical backup of the server to
> +        * be useful as a read only standby.
> +        */
> +       GetRunningTransactionData();
> +
> +       /*
>          * If archiving is enabled, rotate the last XLOG file so that all the
>          * remaining records are archived (postmaster wakes up the archiver
>          * process one more time at the end of shutdown). The checkpoint
> 

I don't think this will do any good where it's placed. The checkpoint
that follows will have its redo-pointer beyond the running-xacts record,
so WAL replay will never see it.

--  Heikki Linnakangas EnterpriseDB   http://www.enterprisedb.com