Re: pgsql: Improve error messages in md.c.
От | Heikki Linnakangas |
---|---|
Тема | Re: pgsql: Improve error messages in md.c. |
Дата | |
Msg-id | 4A7A7506.30108@enterprisedb.com обсуждение исходный текст |
Ответ на | Re: pgsql: Improve error messages in md.c. (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: pgsql: Improve error messages in md.c.
|
Список | pgsql-committers |
Tom Lane wrote: > While reading your commit message, it occurred to me that perhaps a > small wording tweak would help. How about 'could not read block 150000 > in file "foo"', rather than "of" file foo? This states correctly that > the block is *in* that file, without implying that the naming of the > block is relative to the file. > > The distinction might be a bit too subtle to help non-native speakers > of English, but it seems to me to read a little better that way. Heh, I had exactly the same idea, and did that in the commit already :-). I'm glad you thought of it too. Me being a non-native speaker of English myself I was not sure how it comes across to someone who is. Perhaps I should've mentioned it in the commit message though, to make note of the subtle difference for future readers of the code. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com
В списке pgsql-committers по дате отправления: