Re: BUG: pgScript NOT thread safe!!
От | Ashesh Vashi |
---|---|
Тема | Re: BUG: pgScript NOT thread safe!! |
Дата | |
Msg-id | 4A448D97.9040107@enterprisedb.com обсуждение исходный текст |
Ответ на | Re: BUG: pgScript NOT thread safe!! (Dave Page <dpage@pgadmin.org>) |
Ответы |
Re: BUG: pgScript NOT thread safe!!
|
Список | pgadmin-support |
<tt>Looks good.<br /> Working fine on linux and windows :)<br /><br /> Dave Page wrote:</tt><blockquote cite="mid:937d27e10906260111w43c18824u86a36bf2ed116948@mail.gmail.com"type="cite"><pre wrap=""><tt>On Fri, Jun 26, 2009 at5:50 AM, Ashesh Vashi<a class="moz-txt-link-rfc2396E" href="mailto:ashesh.vashi@enterprisedb.com"><ashesh.vashi@enterprisedb.com></a>wrote: </tt></pre><blockquote type="cite"><pre wrap=""><tt>That's really weird. I tried that patch on windows and found that - the behavior of wxMutex is not as expected. :( On Gtk (Ubuntu 9.04 32bit), the message-box does not adjust to the length of the title message. (Please find the attached screen-shot.) Please find the updated patch, it is working on gtk & windows both. Though it has not been tested on Osx, but I think - it should work. </tt></pre></blockquote><pre wrap=""><tt> Per IM discussion, I've removed the mutex altogether. This code all gets called in the primary UI thread, so there's actually no concurrency issue until the script actually starts, thus we can protect it with a simple static bool. I suspect this is why the mutex didn't behave as expected - it's intended to keep different threads out of the protected area. Tests OK on OSX.</tt> </pre></blockquote><tt></tt><div class="moz-signature"><tt>-- <br /></tt><div class="moz-signature"><tt><font color="#666666">Thanks & Regards,<br /> Ashesh Vashi<br /><br /> EnterpriseDB INDIA:<a href="http://www.enterprisedb.com">http://www.enterprisedb.com</a></font></tt></div></div>
В списке pgadmin-support по дате отправления: