Re: BUG: pgScript NOT thread safe!!

Mickael Deloison wrote:
> 2009/6/25 Magnus Hagander <magnus@hagander.net>:
>> Ashesh Vashi wrote:
>>>  Hi Dave,
>>>
>>> This patch does the job.
>>> But, it will not be able disable to toolbar buttons on each windows.
>>> Introduced a static variable of type wxMutex for these operations.
>>>
>>> Please take a look at it.
>> I'd rather see something that throws up a messagebox informing the user
>> that parallel execution of pgscript is not supported, if this is the
>> route we have to go down.
>>
>> --
>>  Magnus Hagander
>>  Self: http://www.hagander.net/
>>  Work: http://www.redpill-linpro.com/
>>
> 
> Hi,
> 
> Very sorry for this bug. I did not take into account the case when one
> uses 2 or more Query tool windows. If one launches two windows, it
> will create two pgsApplication. However, it will use the same
> Flex/Bison parser. Actually I can''t do anything about Flex & Bison
> not supporting multiple threads.

Admitting to not remembering the code around this:

Can we put the mutex around just the flex/bison part? Meaning is the
output they generate ok, just not the intermediate state?

I bet the flex/bison step is very short -whereas the execution of the
full script can take a long time..



-- Magnus HaganderSelf: http://www.hagander.net/Work: http://www.redpill-linpro.com/