Re: Patch: Crash on linux-x64
| От | Ashesh Vashi |
|---|---|
| Тема | Re: Patch: Crash on linux-x64 |
| Дата | |
| Msg-id | 49B78F54.6040401@enterprisedb.com обсуждение исходный текст |
| Ответ на | Re: Patch: Crash on linux-x64 (Dave Page <dpage@pgadmin.org>) |
| Ответы |
Re: Patch: Crash on linux-x64
|
| Список | pgadmin-hackers |
Hi Dave,
Dave Page wrote:
In wxWidgets, It starts searching the node starts with the pressed character from the selected node.
If no such node found, it start searching the similar node from the ROOT node.
In our function (FindItem), we look for the children, grand-children and siblings below the selected node as the search criteria.
Dave Page wrote:
okCouple of thoughts about the patch... We should use #ifdef __WXGTK__ not __LINUX__ as we also support *BSD and Solaris, *but*, although the bug only occurs on Linux,
I think yes - that will make the behaviour consistent on all the platform.Should we just use this search code on all platforms for consistency and future enhancement?
In wxWidgets, It starts searching the node starts with the pressed character from the selected node.
If no such node found, it start searching the similar node from the ROOT node.
In our function (FindItem), we look for the children, grand-children and siblings below the selected node as the search criteria.
:)Don't worry about submitting a new patch - I'll hack up whats there based on what we decide.
--
В списке pgadmin-hackers по дате отправления: