Re: Server Status window work

Dave Page a écrit :
> On Wed, Feb 25, 2009 at 7:35 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>
>> Fixed with your "truly horrible kludge". The wxTimer is set to half a
>> second, and it doesn't enough on Mac. Maybe 400ms would be better.
>
> Doesn't seem too bad to me - my guess was originally for 250ms though.
>

I put 400ms, but we can have a lower value if you want.

>> Done. I finally understood what's in the perspective. I finally found
>> editing the string manually was a better way.
>
> Yeah, I often do that.
>
>> I still didn't change the listview with a textbox for the Logfile pane.
>> It's a big work and I would prefer to finish this one before doing the
>> change.
>>
>> See the attached patch.
>
> Now we're cookin' :-). This is much more usable. There are still some
> minor issues - let's get these sorted and get it into SVN. We can fix
> anything else that crops up from there. Today's testing was performed
> on OS X.
>
> - Do we still need all the OnSel... event handlers?
>

Yes, we need them on GTK. On GTK, if I click on a listview, the
associated pane is not activated. I need to click on the title bar of
the pane to really activate the pane.

> - The log controls (combo box/button) only get activated if a log line
> is selected. The should be active whenever the pane is active (if the
> log is empty - you can't choose another for example!).
>

Fixed.

> - The cancel query button remained active even when I had selected the log pane.
>

Fixed.

> - The default layout still needs a small tweak. The attached
> screenshot is what I get if I remove all frmStatus settings (except
> the timers) from the prefs file.
>

I don't have this issue on my MacMini.

> There is also still something weird going on with the Default View
> option. Once it's in SVN I'll check that some more as it may be
> related to the fact that we don't have the SVN revision in the right
> places in frmStatus.h yet.
>

Seems to work on GTK. I'll take a look on my Mac.

> Tell me - why do you always pick the difficult jobs to work on? :-p
>

Because they tend to be the interesting ones? :)

Moreover, if I really wanted to work on hard items, I'll try to work on
the grid view (adding sort and filter on them, something like sqlmanager
can do - see
http://sqlmanager.net/products/postgresql/manager/screenshots/1561).

New patch attached.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com