Re: Server Status window work

Dave Page a écrit :
> On Thu, Feb 12, 2009 at 11:09 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>
>> The patch attached takes care of this. It's not really finished but it
>> gives an idea of what could be done. There's also the combo stuff. I
>> would love to get comments on this, to see if I go further.
>
> I immediately got an assertion (well, four):
> [...]
> I suspect, that was because of the existing refresh rate(s) being
> stored in the registry.
>

Sorry, I should have warned you...

> Aside from that, I quite like this layout :-) A few thoughts, in no
> particular order:
>
> - The layout is not being restored when the window is re-opened.
> Should be easy to do - the code already exists in other forms.
>

The part of this code is commented on the patch. I should have better
looked at the patch before sending it.

> - The main pane on the right should perhaps be the log pane, as thats
> the one that will usually have lots of info in it, even on a developer
> system with no other users.
>

Done.

> - Can we move the per-pane controls to a single toolbar at the top of
> the form, and have that display only the controls for the active pane?
> That would be a lot tidier I think, and would largely solve the
> pane-too-small-tools-truncated-or-obscured problem. There is a flag to
> the AUI manager to have it highlight the top bar of the active pane
> iirc, so it should be obvious which pane a user would be modifying.
>

I'll look at this.

Thanks for your comments, and sorry for the assertion.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com